Add appearance setting to adjust tab size #17469
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15561
Description
Previously, tab characters on GitHub Desktop were always rendered at 8 spaces in width, in constrast to the site offering several options for tab size. This PR serves to add that functionality; though, instead of a list of integers, it instead utilizes a TextBox. Any input will be converted to a number and, if valid, clamped between 1 and 16. Much like themes, this setting will update the appearance in realtime
Though not strictly required, I'd highly recommend this be added either alongside or sometime after Render tab characters properly in diffs #17428. The current tab display is broken, with values under 5 being erroneously truncated for the first character in a line. As such, the ability to access lower values is likely to display erroneously as-is, and this kind of update would be far better suited for an environment where the functionality is working as expectedMerged!Screenshots
Example taken using #17428
23-09-30.12-42-53.GitHubDesktop-dev.mp4
Release notes
Notes: [New] Allow customizing tab character width in spaces