feat: add an option to disable moving the discarded changes to Trash

[aminya]

Closes #10445
Remedy for #7155

Description

This adds an option to disable moving the discarded changes to Trash, i.e. permanently discard.

Screenshots

Release notes

Notes:

• feat: add an option to disable moving the discarded changes to Trash

[MichaIng]

Many thanks, such an important feature.

• The "Do not show this message again" checkbox refers to the discard confirmation prompt itself, not the trash bin choice, right?
• If so, if you choose to not show the confirmation prompt again, you cannot uncheck the trash bin usage? If so, is the trash bin choice saved for all future files/discards?
• I have not tested in a while, but discarding multiple files seems to always enforce a confirmation, hence no "do not show again" checkbox?
• Finally, I think it would be great to have the checkbox in the regular options GUI as well, to not solely rely on the confirmation dialog. But that should not be a blocker for this PR.

[aminya]

You're welcome!

The "Do not show this message again" checkbox refers to the discard confirmation prompt itself, not the trash bin choice, right?
If so, if you choose to not show the confirmation prompt again, you cannot uncheck the trash bin usage? If so, is the trash bin choice saved for all future files/discards?
I have not tested in a while, but discarding multiple files seems to always enforce a confirmation, hence no "do not show again" checkbox?

I didn't touch the code related to "do not show". Whatever logic you have there should work as expected independently.

Finally, I think it would be great to have the checkbox in the regular options GUI as well, to not solely rely on the confirmation dialog. But that should not be a blocker for this PR.

I added that in bdd16a6

[aminya]

@niik Any update on merging this?

[lofcz]

Is there something blocking the merge? Just had to discard 15k files, github desktop client didn't even finish after hours, git reset HEAD && git clean -fd took ~10 seconds.