Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Commit

Permalink
Merge pull request #39 from derekcsm/release_tweaks
Browse files Browse the repository at this point in the history
1.5.0 release tweaks
  • Loading branch information
derekcsm committed May 4, 2016
2 parents b1de621 + 5e938d7 commit 9f731ed
Show file tree
Hide file tree
Showing 11 changed files with 94 additions and 770 deletions.
33 changes: 19 additions & 14 deletions README.md
Expand Up @@ -4,7 +4,7 @@ Discover and read about the Hubble Telescope's best images.
![icon](http://i.imgur.com/wEWW2OH.png)

----
### [Google Play listing →](https://play.google.com/store/apps/details?id=com.getflow.tasks)
### [Google Play listing →](https://play.google.com/store/apps/details?id=com.derek_s.hubble_gallery)


Maintained by [derekcsm](http://derekcsm.xyz/)
Expand All @@ -13,19 +13,24 @@ Contributions by:

- [PedroVictorB](https://github.com/PedroVictorB)

## General code style
General code style
-------

- use 2 space `indents` and 4 space `continuation indents` for Java and Kotlin, and 2 space for indents & continuation in XML, we're slowing moving to that
- try your best not to exceed horizontal line length
- don't include "created by" tags at top of classes, and if you find one remove it

## Things to do

- write tests for details activity
- re-write remaining classes from Java to Kotlin
- reconsider & improve Dagger2 implementation
- add shared element transition animation to details activity
- re-implement details activity loading
- improve details view layout setup
- use RecyclerView for main grid list
- improve Toolbar show/hide on scroll
- don't include "created by" or any other tags at top of classes, if you find any please remove them

License
-------

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
4 changes: 2 additions & 2 deletions app/build.gradle
Expand Up @@ -29,8 +29,8 @@ android {
compileSdkVersion 23
buildToolsVersion "23.0.2"

def verName = "1.2.5"
def verCode = 16
def verName = "1.5.0"
def verCode = 20

defaultConfig {
applicationId 'com.derek_s.hubble_gallery'
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/AndroidManifest.xml
Expand Up @@ -30,10 +30,6 @@
android:value=".act_main.ActMain"/>
</activity>

<meta-data
android:name="io.fabric.ApiKey"
android:value="86709631566e2c951c17207f1f0c8f7fbd20ccfc"/>

<activity
android:name=".ui.activities.ActWelcome"
android:label="@string/title_activity_act_onboarding">
Expand Down
Expand Up @@ -2,6 +2,8 @@

import android.content.Intent;
import android.os.Bundle;
import android.text.Html;
import android.text.method.LinkMovementMethod;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
Expand All @@ -23,7 +25,7 @@ public class FragWelcomeInfo extends FragBase {

private static int pagePos = 1;

public static final FragWelcomeInfo newInstance(int position) {
public static FragWelcomeInfo newInstance(int position) {
final FragWelcomeInfo fragment = new FragWelcomeInfo();
// Supply int position as an argument.
Bundle args = new Bundle();
Expand Down Expand Up @@ -68,7 +70,8 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
tvInfo.setText(getActivity().getResources().getText(R.string.info_2));
break;
case (3):
tvInfo.setText(getActivity().getResources().getText(R.string.info_3));
tvInfo.setText(Html.fromHtml(getActivity().getResources().getString(R.string.info_3)));
tvInfo.setMovementMethod(LinkMovementMethod.getInstance());
break;
case (4):
tvInfo.setVisibility(View.INVISIBLE);
Expand Down

0 comments on commit 9f731ed

Please sign in to comment.