added more german nobility titles #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "king's", | ||
| "king’s", |
There was a problem hiding this comment.
Suggestion from my side would be to normalize the apostrophes and dashes prior to matching against these lists. There are too many variations to capture them all.
There was a problem hiding this comment.
Absolutely agreed; I did not take the time to take a look if this happens already somewhere in the code… Obviously there's a bunch of misused characters that might function as apostrophes, even if we only take into account latin script, e.g. '’‘' and the backtick that ` creates the <code/>. Search the unicode.org charts for all other apostrophes for other writing systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the question on "frau" (in #99), I dropped in a couple more titles from German language (specifically from nobility titles of 19th century Austrian government members).