Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to eslint9 #4462

Merged
merged 7 commits into from
May 17, 2024
Merged

chore: upgrade to eslint9 #4462

merged 7 commits into from
May 17, 2024

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented May 14, 2024

Upgrade to eslint v9 flat config. Custom eslint rules have been tested and work in the new config file. Removed unused vars in try catch blocks due to breaking change in eslint v9. Use globals to include globals env

@michael-siek michael-siek marked this pull request as ready for review May 15, 2024 06:50
@michael-siek michael-siek requested a review from a team as a code owner May 15, 2024 06:50
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have a thought about the .only plugin to consider.

package.json Show resolved Hide resolved
@michael-siek michael-siek requested a review from dbjorge May 16, 2024 16:46
eslint.config.js Show resolved Hide resolved
eslint.config.js Show resolved Hide resolved
@michael-siek michael-siek merged commit f584e8e into develop May 17, 2024
21 checks passed
@michael-siek michael-siek deleted the eslint9 branch May 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants