Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up vscode config to attach to test:debug #4430

Merged
merged 2 commits into from Apr 26, 2024

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Apr 25, 2024

This updates the existing test:debug run script to pass --remote-debugging-port to chrome, and then sets up a vscode launch profile to connect to that port.

No QA required.

@dbjorge dbjorge requested a review from a team as a code owner April 25, 2024 21:50
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested without vscode and it doesn't break running test:debug.

"request": "attach",
"name": "Attach to Karma test:debug",
"address": "localhost",
"port": 9765, // keep in sync with debugPort in karma.conf.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does .vscode not mind the comment in a json file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does .vscode not mind the comment in a json file?

Copy link
Contributor Author

@dbjorge dbjorge Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it supports this. https://code.visualstudio.com/docs/languages/json#_json-with-comments

In addition to the default JSON mode following the JSON specification, VS Code also has a JSON with Comments (jsonc) mode. This mode is used for the VS Code configuration files such as settings.json, tasks.json, or launch.json.

@dbjorge dbjorge merged commit 5c5ede0 into develop Apr 26, 2024
21 checks passed
@dbjorge dbjorge deleted the karma-vscode-debugging branch April 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants