New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria-roles): correct abstract roles (types) for aria-roles #4421
Commits on Apr 22, 2024
-
fix(aria-roles): correct abstract roles (types) for aria-roles
Too many aria roles were set to widget or otherwise were incorrect, added a comment source for where I got my information for which abstract roles were the type of which roles Refs: #4371
Configuration menu - View commit details
-
Copy full SHA for 69f778b - Browse repository at this point
Copy the full SHA 69f778bView commit details -
fix(aria-roles): table with role application is structure
Previously there was a test to confirm a table with role of application was a data table, but the spec indicates that has an anstract role of structure meaning this should be a structure table instead This commit is just a test correction Refs: #4421
Configuration menu - View commit details
-
Copy full SHA for ffe37f6 - Browse repository at this point
Copy the full SHA ffe37f6View commit details -
fix(aria-roles): inline widgets consider composite type
widget not inline rule corrected isWidgetType check to consider composite widget types
Configuration menu - View commit details
-
Copy full SHA for aa1aa20 - Browse repository at this point
Copy the full SHA aa1aa20View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd59e8d - Browse repository at this point
Copy the full SHA fd59e8dView commit details
Commits on Apr 25, 2024
-
fix(aria-roles): address pr comments
- learned sometimes we intentionally spec change - added `window` as a supported type, and `composite` which was missing from the readme - undid my change to `isWidgetType` Refs: #4371
Configuration menu - View commit details
-
Copy full SHA for 2d185f6 - Browse repository at this point
Copy the full SHA 2d185f6View commit details -
fix(aria-roles): reverted test change as well
test change was only for data tables, but we didn't want to keep that type change Refs: #4371
Configuration menu - View commit details
-
Copy full SHA for 417e6b1 - Browse repository at this point
Copy the full SHA 417e6b1View commit details -
fix(aria-roles): exception for focus-order-semantics
add `window` to has-widget-role, renamed Refs: #4371
Configuration menu - View commit details
-
Copy full SHA for facd65f - Browse repository at this point
Copy the full SHA facd65fView commit details -
fix(aria-roles): updated locales
better pass/fail english message, removed outdated translations Refs: #4371
Configuration menu - View commit details
-
Copy full SHA for bfa95ae - Browse repository at this point
Copy the full SHA bfa95aeView commit details
Commits on Apr 29, 2024
-
Revert "fix(aria-roles): exception for focus-order-semantics"
Addresses some feedback from Wilco in the PR that this isn't the change we want This reverts commit facd65f.
Configuration menu - View commit details
-
Copy full SHA for a07c488 - Browse repository at this point
Copy the full SHA a07c488View commit details -
fix(aria-roles): support window role in valid-scrollable-semantics
reflected in focus-order-semantics
Configuration menu - View commit details
-
Copy full SHA for f11c03f - Browse repository at this point
Copy the full SHA f11c03fView commit details -
fix(aria-roles): window roles and marque/timer expectations in focus-…
…order-semantics addressing more pr feedback
Configuration menu - View commit details
-
Copy full SHA for d856316 - Browse repository at this point
Copy the full SHA d856316View commit details -
Revert "fix(aria-roles): updated locales"
This reverts commit bfa95ae.
Configuration menu - View commit details
-
Copy full SHA for dc966d3 - Browse repository at this point
Copy the full SHA dc966d3View commit details -
fix(aria-roles): log and status allowed in focus-order-semantics
extends prior work by accounting for all standards aria roles changes
Configuration menu - View commit details
-
Copy full SHA for 9b15ae0 - Browse repository at this point
Copy the full SHA 9b15ae0View commit details -
fix(aria-roles): target-size tests consider changed aria roles
last feedback yay
Configuration menu - View commit details
-
Copy full SHA for 5594d8f - Browse repository at this point
Copy the full SHA 5594d8fView commit details