Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-roles): correct abstract roles (types) for aria-roles #4421

Merged
merged 14 commits into from May 2, 2024

Commits on Apr 22, 2024

  1. fix(aria-roles): correct abstract roles (types) for aria-roles

    Too many aria roles were set to widget or otherwise were incorrect, added a comment source for where I got my information for which abstract roles were the type of which roles
    
    Refs: #4371
    gaiety-deque committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    69f778b View commit details
    Browse the repository at this point in the history
  2. fix(aria-roles): table with role application is structure

    Previously there was a test to confirm a table with role of application was a data table, but the spec indicates that has an anstract role of structure meaning this should be a structure table instead
    
    This commit is just a test correction
    
    Refs: #4421
    gaiety-deque committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ffe37f6 View commit details
    Browse the repository at this point in the history
  3. fix(aria-roles): inline widgets consider composite type

    widget not inline rule corrected isWidgetType check to consider composite widget types
    gaiety-deque committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    aa1aa20 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    fd59e8d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. fix(aria-roles): address pr comments

    - learned sometimes we intentionally spec change
    - added `window` as a supported type, and `composite` which was missing from the readme
    - undid my change to `isWidgetType`
    
    Refs: #4371
    gaiety-deque committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2d185f6 View commit details
    Browse the repository at this point in the history
  2. fix(aria-roles): reverted test change as well

    test change was only for data tables, but we didn't want to keep that type change
    
    Refs: #4371
    gaiety-deque committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    417e6b1 View commit details
    Browse the repository at this point in the history
  3. fix(aria-roles): exception for focus-order-semantics

    add `window` to has-widget-role, renamed
    
    Refs: #4371
    gaiety-deque committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    facd65f View commit details
    Browse the repository at this point in the history
  4. fix(aria-roles): updated locales

    better pass/fail english message, removed outdated translations
    
    Refs: #4371
    gaiety-deque committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bfa95ae View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Revert "fix(aria-roles): exception for focus-order-semantics"

    Addresses some feedback from Wilco in the PR that this isn't the change
    we want
    
    This reverts commit facd65f.
    gaiety-deque committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a07c488 View commit details
    Browse the repository at this point in the history
  2. fix(aria-roles): support window role in valid-scrollable-semantics

    reflected in focus-order-semantics
    gaiety-deque committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f11c03f View commit details
    Browse the repository at this point in the history
  3. fix(aria-roles): window roles and marque/timer expectations in focus-…

    …order-semantics
    
    addressing more pr feedback
    gaiety-deque committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d856316 View commit details
    Browse the repository at this point in the history
  4. Revert "fix(aria-roles): updated locales"

    This reverts commit bfa95ae.
    gaiety-deque committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dc966d3 View commit details
    Browse the repository at this point in the history
  5. fix(aria-roles): log and status allowed in focus-order-semantics

    extends prior work by accounting for all standards aria roles changes
    gaiety-deque committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9b15ae0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5594d8f View commit details
    Browse the repository at this point in the history