Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete #4418

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete #4418

merged 2 commits into from Apr 29, 2024

Commits on Apr 19, 2024

  1. fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete 

    if an element has both aria-controls and aria-haspopup mark it incomplete as we are unsure if the DOM element will be added dynamically later

Refs: #4363
    @gaiety-deque
    gaiety-deque committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    551ba24 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix(aria-valid-attr-value): more thorough test coverage 

    - messageKey added to unit test
- integration test

Refs: #4363
    @gaiety-deque
    gaiety-deque committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a823712 View commit details
    Browse the repository at this point in the history