Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(region): Decorative images ignored by region rule #4412

Merged
merged 11 commits into from May 3, 2024
Merged

fix(region): Decorative images ignored by region rule #4412

merged 11 commits into from May 3, 2024

Commits on Apr 16, 2024

  1. fix(region): img alt='' ignored by region rule 

    added isPresentationGraphic check which currently only handles alt='' and ignores them for the region rule
svg I believe is handled differently already
role='presentation' test added as well, use-case already handled

fix: #4145
    @gaiety-deque
    gaiety-deque committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ace25cd View commit details
    Browse the repository at this point in the history

  2. fix(region): replaces tabs for spaces in prior commit 

    my IDE was adding tabs ew, replaced with spaces

Refs: #4145
    @gaiety-deque
    gaiety-deque committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7c810e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'develop' into region-rule-ignores-decorative-image

    @gaiety-deque
    gaiety-deque committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    70b6ddb View commit details
    Browse the repository at this point in the history

  2. add suggested isShallowlyHidden instead of presentational

    @gaiety-deque
    gaiety-deque committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f914665 View commit details
    Browse the repository at this point in the history

  3. rely on getRole instead of adding hasGlobalAttr and focusable unecess… 

    …arily
    @gaiety-deque
    gaiety-deque committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    be633af View commit details
    Browse the repository at this point in the history

  4. additional test for overwritten role with nested child content

    @gaiety-deque
    gaiety-deque committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d515329 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'develop' into region-rule-ignores-decorative-image

    @gaiety-deque
    gaiety-deque committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bc6dc71 View commit details
    Browse the repository at this point in the history

  2. Update lib/checks/navigation/region-evaluate.js 

    Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
    @gaiety-deque @WilcoFiers
    gaiety-deque and WilcoFiers committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b29a90d View commit details
    Browse the repository at this point in the history

  3. additional test coverage

    @gaiety-deque
    gaiety-deque committed May 2, 2024
    Configuration menu
    Copy the full SHA
    53782f2 View commit details
    Browse the repository at this point in the history

  4. targeted test failure cases

    @gaiety-deque
    gaiety-deque committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8938496 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Update test/integration/full/region/region-pass.html 

    Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
    @gaiety-deque @WilcoFiers
    gaiety-deque and WilcoFiers committed May 3, 2024
    Configuration menu
    Copy the full SHA
    738e9e2 View commit details
    Browse the repository at this point in the history