-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: add limits and resources to istio gateway deployment #119
Open
D1sko
wants to merge
4
commits into
deployKF:main
Choose a base branch
from
D1sko:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei M <12621726+D1sko@users.noreply.github.com>
thesuperzapper
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments.
generator/templates/manifests/deploykf-core/deploykf-istio-gateway/values.yaml
Outdated
Show resolved
Hide resolved
generator/templates/manifests/deploykf-core/deploykf-istio-gateway/values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrei M <12621726+D1sko@users.noreply.github.com>
4 tasks
I have also made a comment in #117 (comment) which shows how to achieve the same thing before this PR is merged. |
D1sko
changed the title
improve: add limits and targetmemoryutilization for istio gateway
improve: add limits and resources to istio gateway deployment
Apr 2, 2024
Signed-off-by: Andrei M <12621726+D1sko@users.noreply.github.com>
Signed-off-by: Andrei M <12621726+D1sko@users.noreply.github.com>
Remediated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #117
This PR exposes the resource limits/requests values and adds the targetmemoryutilization metric for autoscaling for the Istio Gateway.