Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't spawn the language server if explicitly disabled settings #1109

Merged
merged 1 commit into from Apr 26, 2024
Merged

fix: don't spawn the language server if explicitly disabled settings #1109

merged 1 commit into from Apr 26, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Apr 26, 2024 •
edited

Don't spawn the language server when deno.enable: false and deno.enablePaths: null, or deno.enablePaths: [].

@bartlomieju
Copy link
Member

I'm not sure if this PR closes that issues completely

@nayeemrmn
Copy link
Collaborator Author

nayeemrmn commented Apr 26, 2024 •
edited

Updated description (was regarding denoland/deno#23577).

@nayeemrmn nayeemrmn merged commit 3b25415 into denoland:main Apr 26, 2024
2 checks passed
@nayeemrmn nayeemrmn deleted the dont-spawn-language-server-on-explicit-disable branch April 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @bartlomieju