Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't pass refs to DELETE #1471

Merged
merged 1 commit into from May 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fast_api.rs
Expand Up @@ -13,14 +13,14 @@ extern "C" {
len: usize,
tys: *const CTypeSequenceInfo,
) -> *mut CTypeInfo;
fn v8__CTypeInfo__DELETE(this: &mut CTypeInfo);
fn v8__CTypeInfo__DELETE(this: *mut CTypeInfo);
fn v8__CFunctionInfo__New(
return_info: *const CTypeInfo,
args_len: usize,
args_info: *const CTypeInfo,
repr: Int64Representation,
) -> *mut CFunctionInfo;
fn v8__CFunctionInfo__DELETE(this: &mut CFunctionInfo);
fn v8__CFunctionInfo__DELETE(this: *mut CFunctionInfo);
}

#[repr(C)]
Expand Down
8 changes: 4 additions & 4 deletions src/inspector.rs
Expand Up @@ -74,7 +74,7 @@ extern "C" {
stack_trace: &mut V8StackTrace,
);

fn v8_inspector__V8InspectorSession__DELETE(this: &mut V8InspectorSession);
fn v8_inspector__V8InspectorSession__DELETE(this: *mut V8InspectorSession);
fn v8_inspector__V8InspectorSession__dispatchProtocolMessage(
session: *mut V8InspectorSession,
message: StringView,
Expand All @@ -88,13 +88,13 @@ extern "C" {
method: StringView,
) -> bool;

fn v8_inspector__StringBuffer__DELETE(this: &mut StringBuffer);
fn v8_inspector__StringBuffer__DELETE(this: *mut StringBuffer);
fn v8_inspector__StringBuffer__string(this: &StringBuffer) -> StringView;
fn v8_inspector__StringBuffer__create(
source: StringView,
) -> UniquePtr<StringBuffer>;

fn v8_inspector__V8Inspector__DELETE(this: &mut V8Inspector);
fn v8_inspector__V8Inspector__DELETE(this: *mut V8Inspector);
fn v8_inspector__V8Inspector__create(
isolate: *mut Isolate,
client: *mut V8InspectorClient,
Expand Down Expand Up @@ -133,7 +133,7 @@ extern "C" {
this: *mut V8Inspector,
stack_trace: *const StackTrace,
) -> *mut V8StackTrace;
fn v8_inspector__V8StackTrace__DELETE(this: &mut V8StackTrace);
fn v8_inspector__V8StackTrace__DELETE(this: *mut V8StackTrace);
}

#[no_mangle]
Expand Down