Refactored OwnedIsolate construction code in prep for lockers #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthmark
commented
Mar 17, 2024
| } | ||
| } | ||
|
|
||
| impl OwnedIsolate { |
There was a problem hiding this comment.
this moved up so destroying an isolate to create a blob was near where isolates are normally destroyed, I can move it back down if wanted though.
Earthmark
added a commit
to Earthmark/rusty_v8
that referenced
this pull request
Mar 17, 2024
This should make the git diff automagically update if/when denoland#1442 goes through
mmastrac
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled the isolate construction changes from the locker API to a separate PR.
This splits annex and scope construction, and disposal, allowing them to be done separately.
This is the pre-work for #1411