Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move import_map and change import_map scopes #2365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

k35o
Copy link

@k35o k35o commented Mar 15, 2024

closes #2364

Comment on lines -2 to -4
"scopes": {
"THIS FILE EXISTS ONLY FOR VSCODE! IT IS NOT USED AT RUNTIME": {}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still correct - the import map is not used to remap anything at runtime, as every Fresh project has it's own import map already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacasonato

THIS FILE EXISTS ONLY FOR VSCODE!

It is written as above, but I think it is used in the lower part and deno.json, but is it necessary?

denoJson.imports = importMap.imports;

IT IS NOT USED AT RUNTIME

Does this part only need?

@k35o k35o requested a review from lucacasonato March 17, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location and description of import_map.json
2 participants