Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kill zombie builds if they complete #2318

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

deer
Copy link
Contributor

@deer deer commented Feb 15, 2024

I was working on a dependency visualizer in order to learn more about deno_graph and various network diagram visualization libraries. I've started out with vis-network, but I quickly encountered a problem when deploying: despite the build() function in build.ts finishing, the process doesn't end!

This is different than #2240 because... I dunno, I just think it is. I've gated the code in the fixture with the standard advice: !Deno.args.includes("build"), but this does not help. But if you comment out Deno.exit() then it starts hanging again. And going a step further, commenting out the code in the effect like this:

      // network.current = new Network(container.current, {
      //   nodes: nodes,
      //   edges: edges,
      // }, {});

causes the build to finish, even though that code isn't even running on the server.

Perhaps I'm going about this wrong and I should instead be importing vis-network dynamically, if we're not in build mode? I'm really unsure what's going on here, but using the code in the forked branch unblocked my project, so I thought I would clean it up enough and write a test -- perhaps it's useful for someone else.

@deer deer marked this pull request as draft February 15, 2024 16:26
@deer
Copy link
Contributor Author

deer commented Feb 15, 2024

Well, this fixes my problem and passes on my computer. I'm not sure what's going on here. I'll look at the failures in more detail tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant