Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): add invert() and invertBy() #4710

Merged
merged 4 commits into from May 12, 2024

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented May 10, 2024

first feature on deno_std 🎉

tackles #4686 and creates first versions for the invert and invertBy functions.

the implementation is inspired by the lodash's invert and invertBy counterparts.

feedback is highly appreciated.

@mbhrznr mbhrznr requested a review from kt3k as a code owner May 10, 2024 22:08
@mbhrznr mbhrznr changed the title feat(collections): add invert and invertBy feat(collections): add invert and invertBy May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (ba0522a) to head (ca99006).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4710   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         477      479    +2     
  Lines       37239    37257   +18     
  Branches     5316     5319    +3     
=======================================
+ Hits        34071    34089   +18     
  Misses       3112     3112           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title feat(collections): add invert and invertBy feat(collections): add invert() and invertBy() May 12, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had to make minor tweaks. Otherwise, very cleanly done! Thank you.

@iuioiua iuioiua merged commit 941f0a3 into denoland:main May 12, 2024
13 checks passed
@mbhrznr mbhrznr deleted the feat/invert branch May 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants