Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(net): improve test coverage #4709

Merged
merged 5 commits into from May 12, 2024
Merged

test(net): improve test coverage #4709

merged 5 commits into from May 12, 2024

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented May 10, 2024

working towards #3713.
pushes code coverage of the net sub-module to 100%.

@mbhrznr mbhrznr requested a review from kt3k as a code owner May 10, 2024 20:12
@github-actions github-actions bot added the net label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (6deab72) to head (450a5f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4709      +/-   ##
==========================================
+ Coverage   91.48%   91.49%   +0.01%     
==========================================
  Files         477      477              
  Lines       37268    37268              
  Branches     5316     5317       +1     
==========================================
+ Hits        34093    34100       +7     
+ Misses       3119     3112       -7     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@kt3k kt3k merged commit 1cd35a6 into denoland:main May 12, 2024
12 checks passed
@mbhrznr mbhrznr deleted the test/net branch May 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants