chore: update check_circular_package_dependencies.ts for workspaces

[kt3k]

_tools/check_circular_package_dependencies.ts was disabled in #4650

This PR re-enables it.

related #4544 #4600

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (3155f00) to head (4815232).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4653      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files         477      477              
  Lines       37334    37334              
  Branches     5325     5325              
==========================================
- Hits        34109    34107       -2     
- Misses       3164     3166       +2     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

I tested this locally by creating a two-way dependency between @std/fs/copy and @std/path/basename and got Circular dependencies found: fs -> path -> fs, which doesn't provide sufficient troubleshooting detail. Can we improve this a little?

[kt3k]

What information would you suggest to add?

[iuioiua]

Just a bit more specificity, such as the exact modules in question. E.g.

Circular dependencies found: fs/copy -> path/basename -> fs/copy

[kt3k]

Sounds a good idea, but that requires fair amount of work. Sounds out of scope of this PR. Created a new issue #4656