Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datetime): improve test coverage #4649

Merged
merged 4 commits into from Apr 28, 2024
Merged

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented Apr 27, 2024

working towards #3713.
pushes code coverage of the datetime sub-module closer to 100%.

currently only misses:

  • a single branch within dateTimeFormatter.format(), which is tagged as FIXME
  • a single branch within dateTimeFormatter.partsToDate(), where the local the format doesn't contain a day and the timezone isn't utc

@mbhrznr mbhrznr requested a review from kt3k as a code owner April 27, 2024 13:29
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (945e8f8) to head (9d3c726).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4649      +/-   ##
==========================================
+ Coverage   91.02%   91.37%   +0.34%     
==========================================
  Files         478      478              
  Lines       37336    37342       +6     
  Branches     5298     5325      +27     
==========================================
+ Hits        33985    34121     +136     
+ Misses       3289     3160     -129     
+ Partials       62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you.

@iuioiua iuioiua merged commit 437ed93 into denoland:main Apr 28, 2024
15 checks passed
@mbhrznr mbhrznr deleted the test/datetime branch April 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants