test(crypto): improve test coverage #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4620 +/- ##
==========================================
+ Coverage 90.89% 90.99% +0.09%
==========================================
Files 475 478 +3
Lines 37325 37383 +58
Branches 5293 5308 +15
==========================================
+ Hits 33927 34016 +89
+ Misses 3336 3305 -31
Partials 62 62 ☔ View full report in Codecov by Sentry. |
iuioiua
requested changes
Apr 21, 2024
There was a problem hiding this comment.
Are you able to target https://app.codecov.io/gh/denoland/deno_std/pull/4620/blob/crypto/crypto.ts#L260 ?
There was a problem hiding this comment.
i've tried by stubbing webCrypto to be able to get into the remaining else block, but no luck so far.
There was a problem hiding this comment.
Actually, that last else clause might be redundant. I'll handle this in a separate PR.
iuioiua
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working towards #3713.
pushes code coverage of the
cryptosub-module closer to 100%.currently the following files aren't at 100%:
_wasm:crypto:webCryptois bound toglobalThis.cryptomy usual strategy ofstubbing didn't seem to work out.webCrypto.subtle.digestever be falsy to begin with?unstable_keystack:Symbol.for("nodejs.util.inspect.custom")i tried to simply importinspectfromnode:utiland compare the outcome, similar on how the test case forSymbol.for("Deno.customInspect")looked like. however this didn't change anything on cov.