test(async): improve test coverage #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
requested changes
Apr 10, 2024
async/pool_test.ts
Outdated
| @@ -22,7 +22,7 @@ Deno.test("pooledMap()", async function () { | |||
| assert(diff < 3000); | |||
| }); | |||
|
|
|||
| Deno.test("pooledMap() handles errors", async () => { | |||
| Deno.test("pooledMap() handles errors", async function () { | |||
There was a problem hiding this comment.
Nit: we generally use the arrow syntax for anonymous functions. Please revert. Ditto elsewhere.
There was a problem hiding this comment.
understood! also took liberty to convert the other test cases in the async sub-module to make use of the arrow syntax as well.
iuioiua
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working towards #3713.
pushes code coverage of the
asyncsub-module closer to 100%.the two remaining files in the sub-module which aren't at 100% are:
mux_async_iterator.ts:resetting the errors via
this.#throws.length = 0seems to be unreachable code.if we have a truthy value for
this.#throws.lengthwe would throw all of the errors, thus exitingiterate.pool.ts:the
catchblock as well as the error handling seems to be covered by tests already.