Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(fmt): add duration() tests #4551

Merged
merged 1 commit into from Apr 7, 2024

Conversation

niklasmtj
Copy link
Contributor

@niklasmtj niklasmtj commented Apr 5, 2024

This should up the code coverage of fmt/duration up to 100%. Not 100% about the second test's name so I'm open to suggestions since we're testing here the default switch case.

This referes to #3713

Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj niklasmtj requested a review from kt3k as a code owner April 5, 2024 20:35
@github-actions github-actions bot added the fmt label Apr 5, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@iuioiua iuioiua changed the title tests: add digital ignore 0 and style TypeError tests(fmt): add duration() tests Apr 7, 2024
@iuioiua iuioiua merged commit 7fe7e31 into denoland:main Apr 7, 2024
13 checks passed
@niklasmtj niklasmtj deleted the tests/fmt-duration branch April 7, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants