Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(encoding): improve test coverage #3971

Merged
merged 3 commits into from Dec 17, 2023
Merged

chore(encoding): improve test coverage #3971

merged 3 commits into from Dec 17, 2023

Conversation

babiabeo
Copy link
Contributor

@babiabeo babiabeo commented Dec 17, 2023 •
edited

Related: #3713

New test cases

_util.ts

  • For object with empty prototype.

ascii85.ts

  • When decoding with default standard option.

base32.ts

  • For byteLength function.
  • When encoding a very long text.

base64url.ts

  • When decoding illegal base64url strings.

varint.ts

  • When encoding overflow uint64.

See: https://app.codecov.io/gh/denoland/deno_std/pull/3971/indirect-changes

@babiabeo babiabeo requested a review from kt3k as a code owner December 17, 2023 11:55
iuioiua
iuioiua approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you very much for helping out with this, David. Much appreciated!

@iuioiua iuioiua merged commit 60f7b20 into denoland:main Dec 17, 2023
12 checks passed
@babiabeo babiabeo deleted the encoding-test-coverage branch December 17, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@babiabeo @iuioiua