Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(async): complete documentation #3887

Merged
merged 5 commits into from Dec 1, 2023
Merged

chore(async): complete documentation #3887

merged 5 commits into from Dec 1, 2023

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Nov 30, 2023

I'm a little unsure of some of the wording I chose, particularly with MuxAsyncIterator. Minor cleanups and inconsistency fixes have also been included.

Towards #3880
Towards #3764

@github-actions github-actions bot added the async label Nov 30, 2023
@iuioiua iuioiua marked this pull request as ready for review November 30, 2023 23:14
@iuioiua iuioiua requested a review from kt3k as a code owner November 30, 2023 23:14
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

async/mux_async_iterator.ts Outdated Show resolved Hide resolved
async/mux_async_iterator.ts Outdated Show resolved Hide resolved
async/mux_async_iterator.ts Outdated Show resolved Hide resolved
async/retry.ts Outdated Show resolved Hide resolved
iuioiua and others added 4 commits December 1, 2023 11:25
Co-authored-by: Luca Casonato <hello@lcas.dev>
Co-authored-by: Luca Casonato <hello@lcas.dev>
Co-authored-by: Luca Casonato <hello@lcas.dev>
@iuioiua iuioiua merged commit e9b2ea3 into main Dec 1, 2023
12 checks passed
@iuioiua iuioiua deleted the async-docs branch December 1, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants