feat: fast check cache and lazy fast check #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c3ed94.
…en building a fast check graph
dsherret
commented
Feb 19, 2024
Comment on lines
+21
to
+23
| // todo(#391): fix this | ||
| import { Private } from "jsr:@scope/c@1"; | ||
| console.log(Private); |
There was a problem hiding this comment.
Since fast check failed on this package, it should still grab this dependency and jsr:@scope/c@1.0.0 should be fast checked. Fixing this is a perf improvement and I'll do it in a future PR. I opened #391
marvinhagemeister
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to do all the setup needed to properly test this, so I'm going to mostly write integration tests in the CLI for the behaviour in here.
Closes #383