Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ts reference paths type-only deps #246

Merged
merged 1 commit into from Mar 6, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Mar 5, 2023

<reference path="..." /> doesn't create a runtime dependency. Extracted from #228.
Prevents the following module from failing on a no-check graph validation:

/// <reference path="./nonexistent.d.ts" />

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@dsherret dsherret merged commit f160d06 into denoland:main Mar 6, 2023
@nayeemrmn nayeemrmn deleted the ts-reference-path-is-type-dep branch March 6, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants