add amazonlinux2 #87
Closed
add amazonlinux2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the vanilla deno executable not "just work" on AL2? |
hayd
reviewed
Nov 20, 2020
| @@ -0,0 +1,75 @@ | |||
| FROM amazonlinux:2.0.20200722.0 | |||
There was a problem hiding this comment.
It's annoying that, unlike for Amazon Linux 1, they don't publish the precise AMI.
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
(I guess it's not a huge deal, but worth noting.)
I feel a bit silly, but I didn't even try that :( |
|
aside: I am going to delete amazonlinux1 soon (edit: it's deleted). |
|
This was wanted more for deno-lambda rather than anyone wanting an amazonlinux2 docker image... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive tested this and it builds and passes the welcome test at the end. I tried to make as minimal changes to the amz1 dockerfile as possible, with one exception: I moved the gcc install/compile above the deno download to reduce the amount that needs to be rebuilt when updating deno versions.
Other notable changes
gzipandtarlibatomicpathmotivdated by deno-lambda