Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lsp): move fields from Documents to LspResolver #23585

Merged
merged 9 commits into from Apr 30, 2024
Merged

refactor(lsp): move fields from Documents to LspResolver #23585

merged 9 commits into from Apr 30, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Apr 27, 2024 •
edited

Moves jsr_resolver, redirect_resolver and graph_imports to LspResolver.

@nayeemrmn nayeemrmn changed the title refactor(lsp): move graph imports from documents to LspResolver refactor(lsp): move jsr resolver and graph imports to LspResolver Apr 29, 2024
@nayeemrmn nayeemrmn changed the title refactor(lsp): move jsr resolver and graph imports to LspResolver refactor(lsp): move fields from Documents to LspResolver Apr 29, 2024
nathanwhit
nathanwhit approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@nayeemrmn nayeemrmn merged commit 5cae343 into denoland:main Apr 30, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-resolver-graph-imports branch April 30, 2024 01:41
littledivy added a commit to littledivy/deno that referenced this pull request May 1, 2024
@littledivy
Revert "refactor(lsp): move fields from Documents to LspResolver (den…
4d56993 
…oland#23585)"

This reverts commit 5cae343.
@nayeemrmn nayeemrmn mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nayeemrmn @dsherret @nathanwhit