chore: migrate bench, publish, and more itests to spec tests

cli/tools/bench/mitata.rs

@@ -386,7 +386,7 @@ pub mod reporter {
         ))
         .unwrap();
         s.push_str(&format!(
-          "\n   {}x times {} than {}",
+          "\n   {}x {} than {}",
           if faster { diff } else { inv_diff },
           if faster { "faster" } else { "slower" },
           b.name

tests/integration/bench_tests.rs

@@ -11,186 +11,18 @@ use util::env_vars_for_npm_tests;
 use util::TestContext;
 use util::TestContextBuilder;
 
-itest!(overloads {
-  args: "bench bench/overloads.ts",
-  exit_code: 0,
-  output: "bench/overloads.out",
-});
-
-itest!(meta {
-  args: "bench bench/meta.ts",
-  exit_code: 0,
-  output: "bench/meta.out",
-});
-
-itest!(pass {
-  args: "bench bench/pass.ts",
-  exit_code: 0,
-  output: "bench/pass.out",
-});
-
-itest!(ignore {
-  args: "bench bench/ignore.ts",
-  exit_code: 0,
-  output: "bench/ignore.out",
-});
-
-itest!(ignore_permissions {
-  args: "bench bench/ignore_permissions.ts",
-  exit_code: 0,
-  output: "bench/ignore_permissions.out",
-});
-
-itest!(fail {
-  args: "bench bench/fail.ts",
-  exit_code: 1,
-  output: "bench/fail.out",
-});
-
-itest!(bench_formatting {
-  args: "bench bench/bench_formatting.ts",
-  exit_code: 0,
-  output: "bench/bench_formatting.out",
-});
-
 itest!(collect {
   args: "bench --ignore=bench/collect/ignore bench/collect",
   exit_code: 0,
   output: "bench/collect.out",
 });
 
-itest!(load_unload {
-  args: "bench bench/load_unload.ts",
-  exit_code: 0,
-  output: "bench/load_unload.out",
-});
-
-itest!(interval {
-  args: "bench bench/interval.ts",
-  exit_code: 0,
-  output: "bench/interval.out",
-});
-
-itest!(quiet {
-  args: "bench --quiet bench/quiet.ts",
-  exit_code: 0,
-  output: "bench/quiet.out",
-});
-
-itest!(only {
-  args: "bench bench/only.ts",
-  exit_code: 1,
-  output: "bench/only.out",
-});
-
-itest!(multifile_summary {
-  args: "bench bench/group_baseline.ts bench/pass.ts bench/multiple_group.ts",
-  exit_code: 0,
-  output: "bench/multifile_summary.out",
-});
-
-itest!(no_check {
-  args: "bench --no-check bench/no_check.ts",
-  exit_code: 1,
-  output: "bench/no_check.out",
-});
-
-itest!(allow_all {
-  args: "bench  --allow-all bench/allow_all.ts",
-  exit_code: 0,
-  output: "bench/allow_all.out",
-});
-
-itest!(allow_none {
-  args: "bench bench/allow_none.ts",
-  exit_code: 1,
-  output: "bench/allow_none.out",
-});
-
-itest!(exit_sanitizer {
-  args: "bench bench/exit_sanitizer.ts",
-  output: "bench/exit_sanitizer.out",
-  exit_code: 1,
-});
-
-itest!(clear_timeout {
-  args: "bench bench/clear_timeout.ts",
-  exit_code: 0,
-  output: "bench/clear_timeout.out",
-});
-
-itest!(finally_timeout {
-  args: "bench bench/finally_timeout.ts",
-  exit_code: 1,
-  output: "bench/finally_timeout.out",
-});
-
-itest!(before_unload_prevent_default {
-  args: "bench --quiet bench/before_unload_prevent_default.ts",
-  output: "bench/before_unload_prevent_default.out",
-});
-
-itest!(group_baseline {
-  args: "bench bench/group_baseline.ts",
-  exit_code: 0,
-  output: "bench/group_baseline.out",
-});
-
-itest!(unresolved_promise {
-  args: "bench bench/unresolved_promise.ts",
-  exit_code: 1,
-  output: "bench/unresolved_promise.out",
-});
-
-itest!(unhandled_rejection {
-  args: "bench bench/unhandled_rejection.ts",
-  exit_code: 1,
-  output: "bench/unhandled_rejection.out",
-});
-
 itest!(filter {
   args: "bench --filter=foo bench/filter",
   exit_code: 0,
   output: "bench/filter.out",
 });
 
-itest!(no_run {
-  args: "bench --no-run bench/no_run.ts",
-  output: "bench/no_run.out",
-  exit_code: 1,
-});
-
-itest!(no_prompt_by_default {
-  args: "bench --quiet bench/no_prompt_by_default.ts",
-  exit_code: 1,
-  output: "bench/no_prompt_by_default.out",
-});
-
-itest!(no_prompt_with_denied_perms {
-  args: "bench --quiet --allow-read bench/no_prompt_with_denied_perms.ts",
-  exit_code: 1,
-  output: "bench/no_prompt_with_denied_perms.out",
-});
-
-itest!(check_local_by_default {
-  args: "bench --quiet bench/check_local_by_default.ts",
-  output: "bench/check_local_by_default.out",
-  http_server: true,
-});
-
-itest!(check_local_by_default2 {
-  args: "bench --quiet bench/check_local_by_default2.ts",
-  output: "bench/check_local_by_default2.out",
-  http_server: true,
-  exit_code: 1,
-});
-
-itest!(bench_explicit_start_end {
-  args: "bench --quiet -A bench/explicit_start_and_end.ts",
-  output: "bench/explicit_start_and_end.out",
-  exit_code: 1,
-});
-
 itest_flaky!(bench_explicit_start_end_low_precision {
   args: "bench --quiet -A bench/explicit_start_and_end_low_precision.ts",
   output: "bench/explicit_start_and_end_low_precision.out",
@@ -214,12 +46,6 @@ itest!(bench_with_malformed_config {
   output: "bench/collect_with_malformed_config.out",
 });
 
-itest!(json_output {
-  args: "bench --json bench/pass.ts",
-  exit_code: 0,
-  output: "bench/pass.json.out",
-});
-
 #[test]
 fn recursive_permissions_pledge() {
   let context = TestContext::default();
@@ -258,21 +84,6 @@ itest!(package_json_basic {
   exit_code: 0,
 });
 
-itest!(bench_lock {
-  args: "bench",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  exit_code: 10,
-  output: "lockfile/basic/fail.out",
-});
-
-itest!(bench_no_lock {
-  args: "bench --no-lock",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  output: "lockfile/basic/bench.nolock.out",
-});
-
 #[test]
 fn conditionally_loads_type_graph() {
   let context = TestContext::default();

tests/integration/check_tests.rs

@@ -145,12 +145,6 @@ itest!(check_imported_files_listed_in_exclude_option {
   exit_code: 1,
 });
 
-itest!(check_with_excluded_file_specified {
-  args: "check lib/types.d.ts",
-  cwd: Some("check/excluded_file_specified/"),
-  output: "check/excluded_file_specified/check.out",
-});
-
 #[test]
 fn cache_switching_config_then_no_config() {
   let context = TestContext::default();
@@ -279,13 +273,6 @@ itest!(check_dts {
   exit_code: 1,
 });
 
-itest!(check_types_dts {
-  args: "check main.ts",
-  cwd: Some("check/types_dts/"),
-  output: "check/types_dts/main.out",
-  exit_code: 0,
-});
-
 itest!(package_json_basic {
   args: "check main.ts",
   output: "package_json/basic/main.check.out",

tests/integration/doc_tests.rs

@@ -106,21 +106,6 @@ itest!(deno_doc_invalid_url {
   exit_code: 1,
 });
 
-itest!(doc_lock {
-  args: "doc main.ts",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  exit_code: 10,
-  output: "lockfile/basic/fail.out",
-});
-
-itest!(doc_no_lock {
-  args: "doc --no-lock main.ts",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  output: "lockfile/basic/doc.nolock.out",
-});
-
 #[test]
 fn deno_doc_html() {
   let context = TestContext::default();

tests/integration/info_tests.rs

@@ -100,21 +100,6 @@ itest!(info_missing_module {
   output: "info/info_missing_module.out",
 });
 
-itest!(info_lock {
-  args: "info main.ts",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  exit_code: 10,
-  output: "lockfile/basic/fail.out",
-});
-
-itest!(info_no_lock {
-  args: "info --no-lock main.ts",
-  http_server: true,
-  cwd: Some("lockfile/basic"),
-  output: "lockfile/basic/info.nolock.out",
-});
-
 itest!(info_recursive_modules {
   args: "info --quiet info/info_recursive_imports_test.ts",
   output: "info/info_recursive_imports_test.out",

tests/integration/lint_tests.rs

@@ -213,48 +213,6 @@ fn lint_with_glob_config_and_flags() {
   assert_contains!(output, "Checked 2 files");
 }
 
-itest!(no_slow_types {
-  args: "lint",
-  output: "lint/no_slow_types/no_slow_types.out",
-  cwd: Some("lint/no_slow_types"),
-  exit_code: 1,
-});
-
-itest!(no_slow_types_entrypoint {
-  args: "lint a.ts",
-  output: "lint/no_slow_types/no_slow_types_entrypoint.out",
-  cwd: Some("lint/no_slow_types"),
-  exit_code: 1,
-});
-
-itest!(no_slow_types_non_entrypoint {
-  args: "lint d.ts",
-  output_str: Some("Checked 1 file\n"),
-  cwd: Some("lint/no_slow_types"),
-  exit_code: 0,
-});
-
-itest!(no_slow_types_excluded {
-  args: "lint --rules-exclude=no-slow-types",
-  output_str: Some("Checked 4 files\n"),
-  cwd: Some("lint/no_slow_types"),
-  exit_code: 0,
-});
-
-itest!(no_slow_types_non_package {
-  args: "lint --config=deno.non-package.json",
-  output_str: Some("Checked 4 files\n"),
-  cwd: Some("lint/no_slow_types"),
-  exit_code: 0,
-});
-
-itest!(no_slow_types_workspace {
-  args: "lint",
-  output: "lint/no_slow_types_workspace/output.out",
-  cwd: Some("lint/no_slow_types_workspace"),
-  exit_code: 1,
-});
-
 #[test]
 fn opt_out_top_level_exclude_via_lint_unexclude() {
   let context = TestContextBuilder::new().use_temp_cwd().build();