Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): read(0) before destroying http2stream #23505

Merged
merged 3 commits into from Apr 30, 2024
Merged

fix(ext/node): read(0) before destroying http2stream #23505

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2ee79
fix(ext/node): read(0) before destroying http2stream
satyarohith Apr 23, 2024
bb02311
Merge branch 'main' into satya/fix_grpc_hello_world
satyarohith Apr 29, 2024
f41a70e
reset CI
satyarohith Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/node/polyfills/http2.ts
View file
Open in desktop
Expand Up @@ -1019,6 +1019,7 @@ export class ClientHttp2Stream extends Duplex {
core.tryClose(this[kDenoResponse].bodyRid);
this.push(null);
debugHttp2(">>> read null chunk");
this.read(0);
this[kMaybeDestroy]();
return;
}
Expand Down