FUTURE: deno install changes
#23498
Merged
FUTURE: deno install changes
#23498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
deno install changesdeno install changes [WIP]
nathanwhit
force-pushed
the
deno_future_install
branch
6 times, most recently
from
c707dc3
to
a16ea92
Compare
nathanwhit
changed the title
deno install changes [WIP]deno install changes
nathanwhit
force-pushed
the
deno_future_install
branch
from
016861f
to
b6c8d6a
Compare
nathanwhit
force-pushed
the
deno_future_install
branch
from
b6c8d6a
to
b8e7dec
Compare
dsherret
reviewed
May 7, 2024
cli/args/flags.rs
Outdated
|
|
||
| flags.subcommand = DenoSubcommand::Install(InstallFlags { | ||
| // TODO(bartlomieju): remove once `deno install` supports both local and | ||
| // global installs |
There was a problem hiding this comment.
I think it still applies, but the message is wrong - we want to keep the field for now so we can warn about the behavior change if the user doesn't pass --global. Updated to reflect that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes we plan to make to
deno installin deno 2.0.deno installwithout arguments caches dependencies frompackage.json/deno.jsonand sets up thenode_modulesfolderdeno install <pkg>adds the package to the config file (eitherpackage.jsonordeno.json), i.e. it aliasesdeno adddeno addcan also add deps topackage.json(this is gated behindDENO_FUTUREdue to uncertainty around handling projects with bothdeno.jsonandpackage.json)deno install -g <bin>installs a package as a globally available binary (the same asdeno install <bin>in 1.0)