fix(cli): panic with deno coverage
#23353
Open
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
deno coveragedeno coverage
|
Thanks for the PR, could you please add a test case that exercises this change? You can add an |
|
My apologies @bartlomieju — I missed your initial reply to this PR. I've gone ahead and added a test at |
bartlomieju
reviewed
May 12, 2024
Comment on lines
+583
to
+588
| assert!( | ||
| actual.contains(expected_message), | ||
| "Expected output to contain '{}', but found:\n{}", | ||
| expected_message, | ||
| actual | ||
| ); |
There was a problem hiding this comment.
You can use assert_contains! macro here to skip manually creating a message
Comment on lines
+611
to
+615
| assert!( | ||
| unexpected_contents.is_empty(), | ||
| "Expected the coverage directory to be empty except for 'empty_dir', but found: {:?}", | ||
| unexpected_contents | ||
| ); |
There was a problem hiding this comment.
It's strange that rustfmt didn't dedent this... oh well
| unexpected_contents | ||
| ); | ||
|
|
||
| println!("No unexpected coverage files found as expected, test concludes successfully."); |
There was a problem hiding this comment.
Maybe skip this line, it won't get printed by default anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly addresses the issue raised in #23282 where Deno panics if
deno coverageis called with--includeregex that returns no matches.I've opted not to change the return value of
collect_summaryfor simplicity and return an emptyHashMapinstead