refactor: redundancy of creating lint instance #23308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wooseok123
changed the title
bartlomieju
reviewed
Apr 10, 2024
cli/tools/lint/mod.rs
Outdated
Comment on lines
61
to
63
| lazy_static! { | ||
| static ref LINTER: Mutex<Option<Linter>> = Mutex::new(None); | ||
| } |
There was a problem hiding this comment.
This seems redundant, you can create it directly in lint_files function
wooseok123
commented
Apr 10, 2024
Comment on lines
222
to
+223
| let has_error = has_error.clone(); | ||
| let linter = create_linter(lint_rules.rules); | ||
| let linter = linter.clone(); |
There was a problem hiding this comment.
@bartlomieju This might works? creating an instance outside the future and cloning it when it is used inside the future.
dsherret
changed the title
dsherret
reviewed
Apr 10, 2024
| @@ -218,7 +220,7 @@ async fn lint_files( | |||
|
|
|||
| futures.push({ | |||
| let has_error = has_error.clone(); | |||
| let linter = create_linter(lint_rules.rules); | |||
There was a problem hiding this comment.
This was only created once. #21876 is out of date and already solved
There was a problem hiding this comment.
Yeah, sorry @wooseok123, it looks like the previous code below is only creating the linter once for the run_parallelized
There was a problem hiding this comment.
Ah, thank you for checking that.
I think it needs to add more test code though.
Making a seperate PR for that would be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue : #21876
I tried to make a singleton of linter instance so that it can be reused. But it's still on progress.