-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spotify Embed #72
base: main
Are you sure you want to change the base?
Conversation
add title
|
Hello, this aims to solve #32
NOT READY TO MERGE
Basically it provides a interface to Spotify iframe snippet, so it's not overly optmized as lite-vimeo and lite-youtube where the iframe only loads on interaction. Should this be done to the Spotify iframe (I don't know how, btw, but could try)?
For reference there's a Svelte and Eleventy library around that utilize this same approach, simple iframe embed.
Found this too: https://github.com/luwes/spotify-audio-element
I couldn't get tests to work, neither by
npm t
, ornpm run test:ci
, actually the latter runs but all fails. But I want to write tests for it.I've tried to use the Spotify oembedAPI but I'm not sure the tradeoffs are worth it. Benefits were having embed html snippet and a 300x300 thumbnail image that would allow us to create a link card component as an option over embedded player (if desired), OTOH more code would be need to allow the current customization options. I'm willing to rewrite if needs so.
Preview:
Thank you.