fix: Do not fail to send images with wrong extensions #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
reviewed
Mar 1, 2024
link2xt
force-pushed
the
main
branch
2 times, most recently
from
1abb12e
to
2af9ff1
Compare
Try to guess the image format based on its content first. Co-authored-by: iequidoo <dgreshilov@gmail.com>
iequidoo
force-pushed
the
link2xt/send-jpeg-as-png
branch
from
dbeb17c
to
115eee2
Compare
iequidoo
approved these changes
Jun 2, 2024
iequidoo
changed the title
link2xt
commented
Jun 3, 2024
| *no_exif_ref = exif.is_none(); | ||
| let mut img = image::open(&blob_abs).context("image decode failure")?; | ||
| // It's strange that BufReader modifies a file position while it takes a non-mut |
There was a problem hiding this comment.
Rewinding file descriptor does not require a mutable reference. Or it's internal mutability (i.e. reader/file takes care of the locks). In any case, if it compiles then it's fine, better remove this comment.
There was a problem hiding this comment.
I tried to remove mut from the file declaration:
435 | file.rewind()?;
| ---- cannot borrow as mutable
So it's not internal mutability (if i understand it correctly). EDIT: and it doesn't work w/o these rewinds
|
@link2xt you can't approve this being the author, so please just merge this if it looks good to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.