feat: Protect From name for verified chats and To names for encrypted chats (#5166) #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
changed the title
Septias
force-pushed
the
sk/display_name_in_protected
branch
from
5b7b83c
to
386258e
Compare
Septias
commented
Jan 16, 2024
iequidoo
reviewed
Jan 16, 2024
Septias
commented
Jan 17, 2024
iequidoo
reviewed
Jan 17, 2024
iequidoo
reviewed
Jan 17, 2024
iequidoo
approved these changes
Jan 18, 2024
Septias
force-pushed
the
sk/display_name_in_protected
branch
from
bb72459
to
d467a55
Compare
link2xt
reviewed
Jan 18, 2024
|
@link2xt are you fine to merge or do you want to look over it again? |
|
This does not currently check if the chat is verified, right? I wonder if it is fine to do for non-verified chat since it does not work with Thunderbird, need more opinions from others. |
For me it's better not to complicate the code with additional checks for compatibility with other MUAs if it's not critical. Anyway we need to create a Thunderbird issue (at least i can't find such one). |
link2xt
force-pushed
the
main
branch
2 times, most recently
from
1abb12e
to
2af9ff1
Compare
|
Taking this over, people ask for this feature here: https://support.delta.chat/t/technical-question-encrypt-profile-names/3049 |
… chats (#5166) If a display name should be protected (i.e. opportunistically encrypted), only put the corresponding address to the unprotected headers. We protect the From display name only for verified chats, otherwise this would be incompatible with Thunderbird and K-9 who don't use display names from the encrypted part. Still, we always protect To display names as compatibility seems less critical here. When receiving a messge, overwrite the From display name but not the whole From field as that would allow From forgery. For the To field we don't really care. Anyway as soon as we receive a message from the user, the display name will be corrected.
iequidoo
force-pushed
the
sk/display_name_in_protected
branch
from
d467a55
to
7c05bb2
Compare
iequidoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5166