-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mark saved messages chat as protected #4981
base: main
Are you sure you want to change the base?
Conversation
Needs test fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me.
i first also thought "what about unencrypted from SELF", but following the exceptions @Hocuri clarified wrt outgoing mails at #4561 (comment) it seems fine, +1
after merging, let's see if all UI really show the green checkmark - saved-messages and device-chats are special in some regards :)
Another option would be to just stamp a green checkmark on Saved messages in the UI :) |
87d0818
to
9cae35e
Compare
Otherwise Autocrypt Setup Message gets encrypted when sent into verified 1:1 chat with self.
Unintended consequence of protecting 1:1 chat is that it is now impossible to disable E2E even if you switch the setting off. Should we:
|
But it's the problem for all 1:1-s, not only for the saved messages' chat, right? off-topicSorry, but i still think that [the only] 1:1 chat is just a misconcept came from other messengers. It should be a usual 2-member group, protected or not, maybe also with protection from adding extra members. Then you can disable e2ee and create another chat.
Probably a solution, but then the green checkmark shouldn't be shown. |
+1 for the solution "if user disabled E2EE, then send messages unencrypted and don't show the green checkmark". Not a priority though, I think for now it's fine to just not mark the saved messages chat as protected, and leave things as they are. |
1abb12e
to
2af9ff1
Compare
Fixes #4561