Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark saved messages chat as protected #4981

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 10, 2023

Fixes #4561

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 10, 2023

Needs test fixes.

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me.

i first also thought "what about unencrypted from SELF", but following the exceptions @Hocuri clarified wrt outgoing mails at #4561 (comment) it seems fine, +1

after merging, let's see if all UI really show the green checkmark - saved-messages and device-chats are special in some regards :)

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 10, 2023

Another option would be to just stamp a green checkmark on Saved messages in the UI :)

Otherwise Autocrypt Setup Message gets encrypted
when sent into verified 1:1 chat with self.
@link2xt
Copy link
Collaborator Author

link2xt commented Nov 12, 2023

test_webxdc_internet_access is still broken, it tests that in 1:1 chat when you disable E2E it actually get disabled, webxdc is sent unencrypted and gets no internet access.

Unintended consequence of protecting 1:1 chat is that it is now impossible to disable E2E even if you switch the setting off.

Should we:

  1. Send unencrypted messages to saved messages chat with a green checkmark if user disabled E2EE?
  2. Say that it is impossible to disable E2EE in saved messages chat?
  3. Do not mark saved messages chat with a green checkmark after all?

@iequidoo
Copy link
Collaborator

Unintended consequence of protecting 1:1 chat is that it is now impossible to disable E2E even if you switch the setting off.

But it's the problem for all 1:1-s, not only for the saved messages' chat, right?

off-topic Sorry, but i still think that [the only] 1:1 chat is just a misconcept came from other messengers. It should be a usual 2-member group, protected or not, maybe also with protection from adding extra members. Then you can disable e2ee and create another chat.

Send unencrypted messages to saved messages chat with a green checkmark if user disabled E2EE?

Probably a solution, but then the green checkmark shouldn't be shown.

@Hocuri
Copy link
Collaborator

Hocuri commented Nov 20, 2023

+1 for the solution "if user disabled E2EE, then send messages unencrypted and don't show the green checkmark". Not a priority though, I think for now it's fine to just not mark the saved messages chat as protected, and leave things as they are.

@link2xt link2xt force-pushed the main branch 2 times, most recently from 1abb12e to 2af9ff1 Compare March 4, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Saved-Messages as verified
4 participants