Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Saved-Messages as verified #4561

Closed
hpk42 opened this issue Jul 20, 2023 · 11 comments · May be fixed by #4981
Closed

Show Saved-Messages as verified #4561

hpk42 opened this issue Jul 20, 2023 · 11 comments · May be fixed by #4981
Labels
verified-chats

Comments

@hpk42
Copy link
Contributor

hpk42 commented Jul 20, 2023

For consistency it makes sense to show saved-messages as verified.
With @Hocuri's recent work merged i'll see a lot of 1:1 verified chats, pretty nice ;)
Am using a pre-release for android (gplay-test-release use with care: https://download.delta.chat/android/beta/deltachat-gplay-release-1.38.2-verifiedchats.apk ) and also core main on desktop.
@Hocuri
Copy link
Collaborator

Hocuri commented Jul 22, 2023

Probably makes sense. The "Saved Messages" chat does contain unencrypted emails sent to self by classical email clients, but since allow protected verified chats to contain unencrypted outgoing emails, in general, the "Saved Messages" chat does satisfy the rules we set for verified chats.

Some of things to decide here:

  • Should the "Device Messages" chat also be marked as verified? I tend to say yes.
  • Do we want to show the "Messages are guaranteed to be end-to-end encrypted from now on." message at the top of the chat? I tend to say yes.

@link2xt
Copy link
Collaborator

link2xt commented Jul 23, 2023

Do we want to show the "Messages are guaranteed to be end-to-end encrypted from now on." message at the top of the chat? I tend to say yes.

I would say no, this introduces a lot of questions, e.g. what to do if the user already has a chat and updates, what if there is currently no chat, when it appears if one device has this chat and the other does not.

Unlike 1:1 chats saved messages chat never becomes verified, it is verified from the start and can never become unverified, so there is no point in time where this message should appear.

Does WhatsApp add such message to the chat with self?

@Hocuri
Copy link
Collaborator

Hocuri commented Jul 24, 2023

WhatsApp doesn't have a dedicated chat with self, you have to create a group with another member and then remove them if you want a chat with yourself. If you do, then yes, there is the "Messages are end-to-end encrypted..." message at the top, though not sure if that counts.

I would say no, this introduces a lot of questions, e.g. what to do if the user already has a chat and updates, what if there is currently no chat, when it appears if one device has this chat and the other does not.

That's a point, not adding it would probably make our lives easier.

@link2xt
Copy link
Collaborator

link2xt commented Jul 25, 2023

WhatsApp doesn't have a dedicated chat with self, you have to create a group with another member and then remove them if you want a chat with yourself.

FAQ says you can just open a 1:1 chat with yourself: https://faq.whatsapp.com/1785465805163404/

@Hocuri
Copy link
Collaborator

Hocuri commented Jul 25, 2023

Interesting, that wasn't possible when I checked last.

Does WhatsApp add such message to the chat with self?

Yes:

image_2023-07-25_08-08-51

@link2xt
Copy link
Collaborator

link2xt commented Jul 25, 2023

This is some special message, I think it is different from what we say ("messages are guaranteed to be encrypted from now on", implying that they were somehow not guaranteed to be encrypted before which is not true for saved messages). We could add some info message like this when saved messages chat is first created, but not worth the effort IMO, easier to just add a blue checkmark and close this issue.

@hpk42
Copy link
Contributor Author

hpk42 commented Jul 25, 2023 via email

@Hocuri
Copy link
Collaborator

Hocuri commented Jul 25, 2023

What about the case where someone uses webmail to send a message to DC (or vice versa)?

If we just follow the same rules as in other chats, then they are allowed in the verified chat:

deltachat-core-rust/src/receive_imf.rs

Lines 2170 to 2180 in f930576

if from_id == ContactId::SELF && chat_type == Chattype::Single {
// For outgoing emails in the 1:1 chat, we have an exception that
// they are allowed to be unencrypted:
// 1. They can't be an attack (they are outgoing, not incoming)
// 2. Probably the unencryptedness is just a temporary state, after all
// the user obviously still uses DC
// -> Showing info messages everytime would be a lot of noise
// 3. The info messages that are shown to the user ("Your chat partner
// likely reinstalled DC" or similar) would be wrong.
return Ok(Verified);
}

So, probably it's fine to just continue showing them in Saved Messages without degrading or showing any warning.

@hpk42
Copy link
Contributor Author

hpk42 commented Jul 26, 2023 via email

@hpk42
Copy link
Contributor Author

hpk42 commented Nov 9, 2023

let's see if someone other than me really cares about "saved messages" and green checkmarks.
Closing the somewhat stale issue until then.

@hpk42 hpk42 closed this as completed Nov 9, 2023
@link2xt link2xt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
@link2xt link2xt mentioned this issue Nov 10, 2023
Open
@iequidoo
Copy link
Collaborator

// 1. They can't be an attack (they are outgoing, not incoming)
But actually they can if the server is hacked. I think, displaying an error like a red exclamation mark would be ok for unencrypted saved messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
verified-chats
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: mark saved messages chat as protected deltachat/deltachat-core-rust
4 participants
@hpk42 @Hocuri @link2xt @iequidoo