Handle 'path' option in http.request for html5 implementation. #8906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'path' parameter handling for html5 implementation in
http.request
function.Fixes #8234
Technical changes
Previously #8234 can appeared because of default value in
dmHttpDDF::HttpResponse::mPath
. Here is part of generated source fileAs we see default value for
m_Path
field is empty string. When we try to rename._httptmp
tom_Path
we checked only pointer, not content.I've added handling of
path
property for html5 implementation because emscripten can work with fopen/fwrite api (it simulates filesystem https://emscripten.org/docs/getting_started/Tutorial.html#using-files. In my example it looks likeResult is
path
passed like './data/....' it doesn't work as expected. Path should be passed like '/data/....'.PR checklist
Example of a well written PR description:
### Technical changes
Technical changes:
Technical notes: