Migrate OSX to GLFW3+ #8348
Open
Migrate OSX to GLFW3+ #8348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jhonnyg
commented
Feb 5, 2024
Comment on lines
570
to
573
| static bool OpenGLIsSupported() | ||
| { | ||
| return (glfwInit() == GL_TRUE); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
If we got this far, we already know we have opengl support
Jhonnyg
commented
Feb 8, 2024
Jhonnyg
added
engine
This reverts commit 420e4a5.
… glfw3-support-for-osx
Jhonnyg
commented
May 16, 2024
| @@ -127,7 +136,6 @@ def configure(conf): | |||
| conf.env['STLIB_HID_NULL'] = 'hid_null' | |||
| conf.env['STLIB_INPUT'] = 'input' | |||
| conf.env['STLIB_LIVEUPDATE'] = 'liveupdate' | |||
| conf.env['STLIB_PLATFORM_NULL'] = 'platform_null' | |||
Jhonnyg
commented
May 16, 2024
Comment on lines
+75
to
77
| bool is_supported = next->m_IsSupportedCb(); | ||
| if (next->m_Priority < selected->m_Priority && is_supported) | ||
| { |
There was a problem hiding this comment.
If we only link with one adapter we never actually do this check..
Jhonnyg
commented
May 16, 2024
| @@ -58,6 +60,7 @@ namespace dmHID | |||
|
|
|||
| void Update(HContext context) | |||
| { | |||
| dmPlatform::PollEvents(context->m_Window); | |||
There was a problem hiding this comment.
Old glfw automatically polls for events when doing a swapbuffers, so the hid_null doesn't respond to any mouse events (like being able to close the window).
vlaaad
previously approved these changes
May 16, 2024
AGulev
previously approved these changes
May 16, 2024
| @@ -55,6 +55,15 @@ namespace dmPlatform | |||
| DEVICE_STATE_KEYBOARD_NUMBER_PAD = 5, | |||
| DEVICE_STATE_KEYBOARD_EMAIL = 6, | |||
| DEVICE_STATE_KEYBOARD_PASSWORD = 7, | |||
| DEVICE_STATE_KEYBOARD_RESET = 8, | |||
| DEVICE_STATE_JOYSTICK_PRESENT = 9, | |||
There was a problem hiding this comment.
this JOYSTICK and GAMEPAD in the same header are so annoying ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have removed our old modified GLFW version on OSX in favour of the latest publicly released GLFW 3.4 version. This will enable us to improve our desktop feature set, as well as help fix many legacy OS issues across the board. When we consider that this work is stable enough on OSX, the rest of the desktop platforms will get updated as well.
Fixes #7970