Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tokenizer] Do not create attention mask for cls pooling #3131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tokenizer] Do not create attention mask for cls pooling #3131

wants to merge 1 commit into from

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Apr 25, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners April 25, 2024 18:52
@xyang16 xyang16 changed the title [tokenizer] Do not set encodings attachment if pooling mode is cls [tokenizer] Do not set encodings attachment for pooling mode cls Apr 25, 2024
@xyang16 xyang16 changed the title [tokenizer] Do not set encodings attachment for pooling mode cls [tokenizer] Do not set encodings attachment for cls pooling Apr 25, 2024
@xyang16 xyang16 force-pushed the embedding branch 2 times, most recently from cb36042 to 9c0feda Compare April 25, 2024 19:03
@xyang16 xyang16 changed the title [tokenizer] Do not set encodings attachment for cls pooling [tokenizer] Do not create attention mask for cls pooling Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu frankfliu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xyang16