-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Build and push deepflow server builder images #5281
base: main
Are you sure you want to change the base?
Conversation
@crazytaxii This image should not need to be built every time.You can set it to be built only when files change |
.github/workflows/server-build.yml
Outdated
"registry.cn-beijing.aliyuncs.com/deepflow-ce/${{ env.BUILDER_IMAGE }}:${{ env.IMAGE_TAG_PREFIX }}-${{ env.IMAGE_TAG }}" | ||
"registry.cn-beijing.aliyuncs.com/deepflow-ce/${{ env.BUILDER_IMAGE }}:${{ env.IMAGE_TAG_PREFIX }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag应该相对固定,builder镜像不适合每次build的tag都更新,应该有一个好记的tag,比如每次改动这个dockerfile时+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉 latest 就够了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不同的分支,可能还需要不同的tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用 ${{ env.IMAGE_TAG_PREFIX }} 这个变量应该就可以了
This PR is for:
Provide the server builder image on public registry
Add a new Dockerfile with 2 steps for building server image easily: