Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFD tutorial #3958

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CFD tutorial #3958

wants to merge 2 commits into from

Conversation

harishwar017
Copy link

Description

Adding Theory Tutorial for Computational Fluid Dynamics (CFD)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@harishwar017
Copy link
Author

harishwar017 commented Apr 18, 2024

@rbharath Please review this PR, I have added tutorial for CFD

@@ -0,0 +1,197 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this on to the CSV files to make sure it gets rendered

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://github.com/deepchem/deepchem.github.io/ for website rendering of tutorials to make sure it gets added

@@ -0,0 +1,197 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the rendering, you will have to add a space after the '###'


Reply via ReviewNB

@@ -0,0 +1,197 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same rendering issue here


Reply via ReviewNB

@@ -0,0 +1,197 @@
{
"nbformat": 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the https://lorenabarba.com/blog/cfd-python-12-steps-to-navier-stokes/ tutorial series for code and examples

@harishwar017
Copy link
Author

harishwar017 commented Apr 19, 2024

I have added the file to the Deep Differential Equations CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants