Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated introduction to bioinformatics #3908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

narashimha05
Copy link

Description

Fix #(issue)
Added additional code examples for MutableSeq.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@davidRFB
Copy link
Contributor

Hi @narashimha05 I Took a look. Thanks. One thing, did you check that the tutorial of Exploring_Quantum_Chemistry_with_GDB1k.ipynb works on colab ? If executed on local from the tutorials folder there is no problem. But if it is executed from colab the file does not exist and then breaks.

For the bioinformatics, in Colab there is these lines:
!curl -Lo conda_installer.py https://raw.githubusercontent.com/deepchem/deepchem/master/scripts/colab_install.py import conda_installer conda_installer.install() !/root/miniconda/bin/conda info -e
Dont think are needed since the pip install --pre deepchem works.

In the PR there is a small addition of the SDF format for the exploring Quantum Chem tutorial
and for the intro to Bioinformatics the additions are simple and complement a bit the MutSequence objects.

@shreyasvinaya @rbharath Do you think this fix can be added in this small PR? or done separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants