wallet: Allow coin type upgrades on simnet #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Feb 7, 2024
This removes the enforced coin type upgrade for simnet wallets, in order to allow testing the upgrade code path under simnet. Prior to this commit, the coin type of a restored simnet wallet was always upgraded to the corresponding SLIP0044 coin type, in order to ensure that the address meant to be used as the mining address for the dcrd node was never made invalid. However, despite this enforced upgrade, there is still a bug with account and address discovery if the wallet was started before at least blocks 1 and 2 were mined in the underlying full node. To alert simnet users about this bug this commit adds a note displayed during simnet wallet creation. In the future, this bug may be fully fixed by ensuring the underlying node is fully synced and has blocks before the sync process completes. This will need to take into account use cases where the underlying node is meant to be fully unsynced (such as air-gapped wallets).
matheusd
force-pushed
the
cointype-upgd-simnet
branch
from
8c25c7c
to
bbb072e
Compare
jrick
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the enforced coin type upgrade for simnet wallets, in order to allow testing the upgrade code path under simnet.
Prior to this commit, the coin type of a restored simnet wallet was always upgraded to the corresponding SLIP0044 coin type, in order to ensure that the address meant to be used as the mining address for the dcrd node was never made invalid. However, despite this enforced upgrade, there is still a bug with account and address discovery if the wallet was started before at least blocks 1 and 2 were mined in the underlying full node.
To alert simnet users about this bug this commit adds a note displayed during simnet wallet creation.
In the future, this bug may be fully fixed by ensuring the underlying node is fully synced and has blocks before the sync process completes. This will need to take into account use cases where the underlying node is meant to be fully unsynced (such as air-gapped wallets).
Required by #2318