*wip* spv: Add batched cfilter fetching #2314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but I want to commit the mixing integration first (mixing is protocol version 10, this is 11, it would strange/incorrect to commit these out of order) ...even though dcrd did just that :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires decred/dcrd#3211
Part of #2289
Draft for the time being, until the upstream requirement is merged, but should be close to the final format.
When the remote peer supports batched cfilter fetching, use that. This allows mixing both peers that support with peers that do not support batched fetching when downloading cfilters, making this useful even while the network is not fully updated.