spv: Move validate header chain difficulties to earlier point in startup sync #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to debug SPV sync issues by allowing more debugging info for the sync process itself, as opposed to all peer messages exchanged.
This moves the header chain difficulty validation to an earlier point in time of the initial sync process. This is preferable so that less work is performed in case invalid headers are received.
jrick
reviewed
Nov 13, 2023
| s.sidechainMu.Unlock() | ||
| return err | ||
| } | ||
| _, err = s.wallet.ValidateHeaderChainDifficulties(ctx, fullsc, 0) |
There was a problem hiding this comment.
This seems fine for now, if only because ValidateHeaderChainDifficulties, despite using a slice of BlockNodes, only actually checks the headers and doesn't need the cfilters to be populated. Since we have the chance to change the API, we may want to change that to take a slice of headers instead (can be in a future change).
jrick
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the header chain difficulty validation to an earlier point in time of the initial sync process.
This is preferable so that less work is performed in case invalid headers are received.
This PR includes a commit to move the p2p package logs to a separate subsystem, so that the syncing process can be logged with a higher logging level while not producing significant log spam due to individually logging each peer message.
Part of #2289