Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtract fee from amount #1370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sefbkn
Copy link
Member

@sefbkn sefbkn commented Jan 8, 2019

Closes #1311
References decred/dcrd#1530

Add option to subtract fee from single, non-change output.

@sefbkn sefbkn force-pushed the feature/dcrwallet-1311-subtractfeefromamount3 branch 2 times, most recently from bf8adb2 to 4acc245 Compare May 16, 2019 05:13
wallet/txauthor/author.go Outdated Show resolved Hide resolved
rpc/jsonrpc/types/walletsvrcmds_test.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
@sefbkn sefbkn force-pushed the feature/dcrwallet-1311-subtractfeefromamount3 branch from 3bef7e9 to 0f1b716 Compare June 20, 2019 21:37
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, approved this accidentally (stupid browser). flagging again so i look the recent changes.

wallet/wallet.go Outdated Show resolved Hide resolved
@sefbkn sefbkn force-pushed the feature/dcrwallet-1311-subtractfeefromamount3 branch from 0f1b716 to ad5e8dc Compare June 21, 2019 00:35
@chappjc
Copy link
Member

chappjc commented Aug 30, 2021

This would be a nice option. If it's still conceptually alright by jrick I expect you'll need to resolve a couple years of conflicts @sefbkn

@jrick
Copy link
Member

jrick commented Aug 30, 2021

Yes, this is still a desired feature.

@sefbkn
Copy link
Member Author

sefbkn commented Sep 7, 2021

This would be a nice option. If it's still conceptually alright by jrick I expect you'll need to resolve a couple years of conflicts @sefbkn

Alright, no problem.

@jholdstock
Copy link
Member

Would also like to see this feature 👍

@sefbkn sefbkn force-pushed the feature/dcrwallet-1311-subtractfeefromamount3 branch 4 times, most recently from 2ac3e38 to 726246c Compare February 19, 2022 04:44
This change adds functionality that allows a user to have
the transaction fee subtracted from the amount sent to a
recipient rather than from a change output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sendtoaddress is missing a subtractfeefromamount option
4 participants