multi: verifyseed rpc #1158
Open
multi: verifyseed rpc #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githubsands
force-pushed
the
verifySeed
branch
10 times, most recently
from
735af84
to
08f0f70
Compare
githubsands
force-pushed
the
verifySeed
branch
6 times, most recently
from
f0a4f28
to
a4c45de
Compare
jrick
requested changes
Aug 19, 2018
githubsands
force-pushed
the
verifySeed
branch
6 times, most recently
from
a6c8b98
to
6819a23
Compare
|
You need to make sure stuff compiles against master and passes ALL travis tests. Until then there is no point in asking for a review. Here are some screenshots of things to look at: And: |
|
@marcopeereboom should of put a [WIP] but didn't want anyone to relook at this til completed. |
githubsands
force-pushed
the
verifySeed
branch
3 times, most recently
from
0a8b6d1
to
2b2ea48
Compare
githubsands
force-pushed
the
verifySeed
branch
2 times, most recently
from
b1a0739
to
ce931c9
Compare
jrick
requested changes
Oct 8, 2018
githubsands
force-pushed
the
verifySeed
branch
3 times, most recently
from
6e765d7
to
3cd4322
Compare
githubsands
force-pushed
the
verifySeed
branch
3 times, most recently
from
0cb1449
to
5f79bc1
Compare
githubsands
force-pushed
the
verifySeed
branch
2 times, most recently
from
ca1d853
to
6fe3255
Compare
githubsands
force-pushed
the
verifySeed
branch
from
314ee95
to
ea63432
Compare
githubsands
force-pushed
the
verifySeed
branch
from
ea63432
to
c578985
Compare
A function deriveCoinTypeKey is created within methods.go that is used in another a new method of the jsonrpc serve VerifySeed. All necessary changes to autogenerate the help for this rpc call are included as well.
Main purpose of this is to quickly test wallet builds that require seeds that are external to the wallet's db
A use case for this is testing verifyseed rpc. Currently rpctest harness' memwallet does not allow for its seed to be changed.
|
This pull request doesn't pass the build tests, has committed merge conflicts in a file only you have touched, commits a 4M executable, and you want me to review this? |
|
This is for #1037 (linking for discoverability). |
|
@jrick thought I had pushed changes. I'll ping you when its here and double checked as ready. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the PR close on the last guy, old ghost branch not appearing on my machine or remotely. Fixed what was needed.