app: Fix registration flow forms #2750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
force-pushed
the
fixBondAssetForm
branch
from
eb520a3
to
86e4ad6
Compare
martonp
changed the title
Comment on lines
1092
to
1103
| refresh () { | ||
| this.setExchange(app().exchanges[this.host]) | ||
| this.setExchange(this.xc) | ||
| } |
There was a problem hiding this comment.
Information about this exchange might have changed in app().exchanges I think.
whatever call site where we open the affected form can add the exchange to |
|
I had rolled a fix into #2737 already, but I'll merge this first |
|
Oops. Made a conflict. |
Fudge. I merged it. |
The registration flow didn't take into account the case where an exchange had not yet been added to user.Exchanges. It assumed the exchange would already be view only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration flow didn't take into account the case where an exchange had not yet been added to user.Exchanges. It assumed the exchange would already be view only.
Closes #2749